Fix retry-mode git context + push refresh commit immediately#761
Merged
Fix retry-mode git context + push refresh commit immediately#761
Conversation
Two bugs from the first real Renovate run (#759) and its retry: 1. workflow_dispatch retry failed at "Resolve PR number and head ref" with "failed to run git: fatal: not a git repository". The step runs BEFORE actions/checkout, so `gh pr view` has no git context to infer the repo from. Added `--repo "$GITHUB_REPOSITORY"` to the three gh pr view calls that run pre-checkout (HEAD_REF + AUTHOR in the retry branch of step "pr", plus BASE in the retry branch of step "eff"). The error message we initially saw ("author ... is not an accepted bot") was just the shell source being echoed by `bash -x`-like output; the actual runtime never got to that point. 2. The refresh commit (~38 files, reference-asset regeneration) was only pushed at the END of the workflow, after the skill. When the skill failed or was cancelled — which it did repeatedly today — the refresh commit died with the runner and PRs ended up with only the one-line YAML bump. Now push the refresh commit as soon as it's created, so the reference-asset work lands on the PR branch independent of skill outcome. This was a pending commit that got orphaned by #760's squash-merge; re-shipping. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two operational issues in the Upstream Release Docs GitHub Actions workflow: (1) workflow_dispatch retry mode failing before checkout due to missing git context for gh pr view, and (2) refreshed reference-asset commits being lost when the later skill step fails/cancels before the final push.
Changes:
- Add
--repo "$GITHUB_REPOSITORY"to pre-checkoutgh pr viewcalls used duringworkflow_dispatchretry mode. - Push the “refresh reference assets” commit immediately after it’s created (before the skill runs), so it persists even if later steps fail/cancel.
ChrisJBurns
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs diagnosed from today's Renovate runs (#759 + its retry 24744962001):
1. workflow_dispatch retry mode: `gh pr view` needs `--repo` pre-checkout
The retry path failed at "Resolve PR number and head ref" with:
The step runs BEFORE `actions/checkout`, so `gh pr view` has no local `.git` to infer the repo from. Added `--repo "$GITHUB_REPOSITORY"` to the three pre-checkout `gh pr view` calls (two in the retry branch of the `pr` step, one in the retry branch of the `eff` step).
The earlier misleading "author ... is not an accepted bot" message in logs was just `bash -x`-style source echoing; the actual runtime never reached that branch.
2. Push the refresh commit immediately (don't batch with skill push)
Across multiple runs today — 24743070052, 24743776702, 24744962001 — the "Commit refreshed reference assets" step created a real local commit (~38 files, all the reference-asset + CRD regen output), but the `git push` only happened at the END of the workflow in the "Commit and push" step AFTER the skill. Every time the skill failed or was cancelled, that final push never ran, and the refresh commit died with the runner.
Example from run 24743070052's log:
```
[manual/upstream-toolhive-v0.23.1 2167ea4]
Refresh reference assets for toolhive v0.23.1
38 files changed, 69 insertions(+), 69 deletions(-)
```
...yet the PR ended up with only the one-line YAML bump.
Fix: push the refresh commit right after creating it. Skill can fail or hang without losing reference-asset updates.
This change was pushed to #760's branch but landed after its squash-merge, so it got orphaned. Re-shipping.
Testing
🤖 Generated with Claude Code